Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restrict duplicate calls to resolveDispute for the same dispute #68

Open
wants to merge 1 commit into
base: fix/oz-audit
Choose a base branch
from
Open

fix: restrict duplicate calls to resolveDispute for the same dispute #68

wants to merge 1 commit into from

Conversation

xorsal
Copy link
Contributor

@xorsal xorsal commented Dec 10, 2024

🤖 Linear

Closes OPT-564

@linear Linear
Copy link

linear bot commented Dec 10, 2024

OPT-564 M-02 `resolveDispute` Can Be Called Repeatedly

@xorsal xorsal changed the base branch from dev to fix/oz-audit December 10, 2024 20:10
ashitakah
ashitakah approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@ashitakah ashitakah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that create a new status which is resolved to avoid to be called multiple times is hardest than create the mapping, but I feel that is a bit more elegant to have it. I let you the decision, if so, I approve. @xorsal @0xShaito

@xorsal
Copy link
Contributor Author

xorsal commented Dec 17, 2024

I wouldn't modify the life cycle of a Dispute at this stage, we'll be merging PRs for one month straight while we consolidate the two pending audits (for prophet-modules and EBO-core).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xShaito 0xShaito 0xShaito approved these changes

@ashitakah ashitakah ashitakah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xorsal @ashitakah @0xShaito